Skip to content

Subscriber per channel#361

Merged
hannahhoward merged 6 commits into
masterfrom
feat/subscriber-per-channel
Jan 13, 2023
Merged

Subscriber per channel#361
hannahhoward merged 6 commits into
masterfrom
feat/subscriber-per-channel

Conversation

@hannahhoward

Copy link
Copy Markdown
Collaborator

Goals

implement #355

Implementation

  • Adds a channel subscriptions class to dispatch events to different channels
  • Removes sending the Open event from CreateNew so subscriptions always catch all events on a channel
  • Adds a TransferOptions var arg pattern to Open calls -- we can add WithTransportConfigurer soon!
  • Adds an integration test
  • bassed on feat: per transfer events callback #358 but with some more flexible impl

@hannahhoward hannahhoward requested a review from rvagg January 11, 2023 03:24
@hannahhoward hannahhoward force-pushed the feat/subscriber-per-channel branch from 3949036 to f4cd254 Compare January 11, 2023 03:25
@hannahhoward hannahhoward force-pushed the feat/subscriber-per-channel branch from f4cd254 to 1da9977 Compare January 11, 2023 03:26
Comment thread errors.go Outdated
Comment thread impl/impl.go Outdated
Comment thread impl/impl.go Outdated

@rvagg rvagg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing something about ErrAlreadySubscribed would be good before merge

hannahhoward and others added 4 commits January 12, 2023 16:13
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Rod Vagg <rod@vagg.org>
@hannahhoward hannahhoward merged commit f936292 into master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants